🎉 Refactor MCP Selenium Grid CLI + 🧰 NEW: Add rich-coverage development script +🐛 Fix Server Warnings #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• 🏗️ Create cli module and restructure application • 🚀 Move helm cli inside mcp selenium grid cli • 🗑️ Remove custom pydantic models, use default Typer validation • 📚 Update README documentation • 🐳 Update Dockerfile for new structure
Falamarcao
force-pushed
the
dev
branch
2 times, most recently
from
6df6906 to
5d8f725
Compare
• 🛠️ Replace strict coverage --fail-under with custom script • 📊 Use MIN_COVERAGE and MARGIN env vars for flexible thresholding • 🚦 Fail only if coverage < (MIN_COVERAGE - COVERAGE_TOLERANCE_MARGIN), warn if within margin • 🔧 Improve CI stability by allowing minor coverage fluctuations
Falamarcao
changed the title
Falamarcao
force-pushed
the
dev
branch
2 times, most recently
from
e8a2978 to
c34017d
Compare
• 📝 Create rich-coverage runner script with uv script dependencies • 🔄 Update Tests GitHub Actions workflow to include new coverage script • ⬆️ Update pre-commit hook versions in .pre-commit-config.yaml • 🚫 Exclude development scripts from package build • 💡 Add documentation for running coverage reports during development
Falamarcao
temporarily deployed
to
pypi-publishing
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 Problem
Before this PR, the MCP Selenium Grid CLI was completely broken and non-functional, which directly impacted user adoption and usage of the tool. Additionally, the server was warning "Duplicate Operation ID" from the FastAPI proxy.
🎯 Solution
This PR completely refactors the CLI architecture to make it functional and maintainable, while also fixing the server warnings.
🎉 refactor(cli): modular MCP Selenium Grid CLI
• 🏗️ Create cli module and restructure application
• 🚀 Move helm cli inside mcp selenium grid cli
• 🗑️ Remove custom pydantic models, use default Typer validation
• 📚 Update README documentation
• 🐳 Update Dockerfile for new structure
🐛 fix(server): suppress FastAPI proxy "Duplicate Operation ID" warning
• 🤫 Silence annoying FastAPI warning that was spamming logs
• 🧹 Clean up server output for better developer experience
🧪 chore(tests): add coverage reporting with threshold checking ✨
• 📊 NEW: Add comprehensive coverage script with comparison logic
• 🎯 Implement minimum coverage threshold (70%) with tolerance margin (5%)
• 🧰 NEW: Add rich-coverage development script with uv script dependencies
• 🚫 Exclude development scripts from package build
• 💡 Add documentation for running coverage reports during development
🚧 Status: Pre-release
⚠️ Ready for AI Agent testing only - Not ready for user consumption yet
• 🤖 AI agents can begin integration testing
• 👷♂️ Further testing and refinement needed before user release
• 🎯 Target: Internal testing with AI agents first
🤖 AI Assistance Disclosure
This PR description was generated with the assistance of AI.
📝 Notes
The CLI is now functional enough for AI agent integration testing! Users will be able to deploy Selenium Grid using the refactored command structure once we complete further testing.