Skip to content

Conversation

@cubap
Copy link
Member

@cubap cubap commented Nov 25, 2024

Possibly breaky, since the conditional it "fixes" was accidentally always truthy before.

fixes #165, but eliminates an always truthy thing
@cubap cubap requested a review from thehabes as a code owner November 25, 2024 22:23
Copy link
Member

@thehabes thehabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed a strange thing there. Bot check is still functioning as perspective from the point of view of TalendAPI hitting /v1/api directly with a bot token.

@thehabes thehabes merged commit 3c44130 into main Apr 15, 2025
3 checks passed
@thehabes thehabes deleted the cubap/issue165 branch April 15, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants