-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-5102] Add save and publish buttons with validation #2120
Merged
bp-cos
merged 8 commits into
CenterForOpenScience:feature/cedar-integration
from
bp-cos:feature/cedar-1.0.14
Feb 1, 2024
Merged
[ENG-5102] Add save and publish buttons with validation #2120
bp-cos
merged 8 commits into
CenterForOpenScience:feature/cedar-integration
from
bp-cos:feature/cedar-1.0.14
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0699396
to
1a65bc1
Compare
969b42c
to
ba9a958
Compare
futa-ikeda
requested changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor things I noticed. Good stuff!
lib/osf-components/addon/components/cedar-metadata-renderer/component.ts
Outdated
Show resolved
Hide resolved
lib/osf-components/addon/components/metadata/metadata-detail/component.ts
Outdated
Show resolved
Hide resolved
adlius
requested changes
Feb 1, 2024
lib/osf-components/addon/components/cedar-metadata-editor/component.ts
Outdated
Show resolved
Hide resolved
01ac060
into
CenterForOpenScience:feature/cedar-integration
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add save and publish buttons with validation
Summary of Changes
Updated the cedar editor, added listeners to valid the metadata record is valid.
Screenshot(s)
Side Effects
Nothing
QA Notes
Test!