-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPM sandcastle #12232
base: main
Are you sure you want to change the base?
GPM sandcastle #12232
Conversation
Thank you for the pull request, @javagl! ✅ We can confirm we have a CLA on file for you. |
I think the 3D Tiles folder would be better, more visible and easier to access from sandcastle.cesium.com. |
I can move it there with the next update. About the wrong metadata values: This is related to the handling of I do have a fix for that locally that "works" for the GPM data. But I'd like to test (and describe/document!) it more thoroughly. |
Edit: This has been updated to build upon #12237 , which therefore should be merged first
Description
Support for the
NGA_gpm_local
extension has recently been added to Cesium JS, via #12204. This (indirectly) includes the possibility to pick metadata values from the GPM PPE (Per-Point Error) textures, by treating them as property textures and apply metadata picking.This PR adds a Sandcastle that demonstrates the GPM visualization.
For now, this Sandcastle is in the
/Development
section, but can easily be moved elsewhere. It includes the option to visualize property texture values, and therefore might eventually replace https://sandcastle.cesium.com/index.html?src=Custom%20Shaders%20Property%20Textures.htmlThe current state is a draft. It already replicates most of the functionality from an existing demo. But unfortunately, there seems to be an issue that is related to scaling and picking the metadata values from property textures for this data set: The picking functionality currently returns wrong values. The reason for this still has to be investigated.
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change