Closes #12278 - added filtering #12279
Conversation
|
Thank you for the pull request, @MNPCMW6444! Welcome to the Cesium community! In order for us to review your PR, please complete the following steps:
Review Pull Request Guidelines to make sure your PR gets accepted quickly. |
|
Thanks for the PR @MNPCMW6444! I can confirm we have a CLA on file for you. |
| @@ -118,8 +118,74 @@ function addGlyphToTextureAtlas(textureAtlas, id, canvas, glyphTextureInfo) { | |||
|
|
|||
| const splitter = new GraphemeSplitter(); | |||
|
|
|||
| // Filter to remove unsupported control characters like RLM (\u200f) | |||
There was a problem hiding this comment.
Can you explain a bit about how this list was determined? Would it make sense to test for a unicode range instead of listing each character individually?
| let text = label._renderedText; | ||
|
|
||
| // Filter out unsupported control characters | ||
| text = filterUnsupportedCharacters(text); |
There was a problem hiding this comment.
Regex operations can be performance intensive. Is there a way we can ensure the operation runs only once for each label text string, as apposed to every time the glyphs need to be rebound?
There was a problem hiding this comment.
I can implement this with a simple .replace(char, '') instead of a RegExp, will it be acceptable?
Co-authored-by: Gabby Getz <[email protected]>
@ggetz Thanks for your CR! |
Description
Issue number and link
#12278
issue #12278
Testing plan
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change