Skip to content

Tag config.users-test as :integration#18

Merged
Jaben merged 1 commit intodevelopfrom
fix/docker-connection-manager-oom
Apr 3, 2026
Merged

Tag config.users-test as :integration#18
Jaben merged 1 commit intodevelopfrom
fix/docker-connection-manager-oom

Conversation

@Jaben
Copy link
Copy Markdown
Member

@Jaben Jaben commented Apr 3, 2026

Summary

  • Tags parse-user-config-test and init-users-test as :integration since they depend on db-init-fixture which requires CouchDB
  • Fixes lein test failing when CouchDB isn't available

Summary by CodeRabbit

  • Chores

    • Updated container image source and added local build configuration to Docker Compose setup.
  • Tests

    • Marked user configuration tests as integration tests for improved test categorization.

These tests use db-init-fixture which needs CouchDB on localhost:5984.
Without the :integration tag they ran in default lein test and failed.
@Jaben Jaben merged commit 040b7c1 into develop Apr 3, 2026
1 check failed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 68a447e2-8369-4075-bb05-5189625c174d

📥 Commits

Reviewing files that changed from the base of the PR and between 10ceb2c and 485da5e.

📒 Files selected for processing (2)
  • docker-compose.yml
  • test/clj/swarmpit/config/users_test.clj

📝 Walkthrough

Walkthrough

The pull request updates the Docker Compose configuration to reference a custom Swarmpit image from GitHub Container Registry and adds a build directive, while also marking two user configuration tests as integration tests via metadata annotations.

Changes

Cohort / File(s) Summary
Docker Compose Configuration
docker-compose.yml
Updated app service image from swarmpit/swarmpit:latest to ghcr.io/changemakerstudios/swarmpit:latest and added build: . directive.
Test Integration Markers
test/clj/swarmpit/config/users_test.clj
Added ^:integration metadata annotation to parse-user-config-test and init-users-test to classify them as integration tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • Update docker-compose to use repo GHCR image #16: Directly related—both PRs modify the same Docker Compose services.app configuration, updating the image reference to the custom GitHub Container Registry image and adding the build: . directive.

Poem

🐰 A docker hop, a registry shift,
Tests now tagged with integration gift,
From public swarms to private halls,
This bunny builds what custom calls! 🏗️

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/docker-connection-manager-oom

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant