Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Custom States Support (AST-83449, AST-83450) #311

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Add Custom States Support (AST-83449, AST-83450) #311

wants to merge 20 commits into from
+427 −319

Conversation

AlvoBen
Copy link
Contributor

@AlvoBen AlvoBen commented Feb 19, 2025 •
edited
Loading

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Changed the flow of triaging from hardcoded states to dynamic states.

References

https://checkmarx.atlassian.net/browse/AST-83450
https://checkmarx.atlassian.net/browse/AST-83449

Testing

Old triaging tests are covering this functionality.
Added integration test for getStates command.
Could not add triage update test of custom state because triage api for custom states is not ready.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – d98733f1-735f-4b5b-850a-93f67c317ed9

Great job, no security vulnerabilities found in this Pull Request

@BenAlvo1
Add name attribute to CustomResultState and update default states ini…
c3d1a27 
…tialization
@BenAlvo1
Remove text attribute from Dynamic Filters group in plugin.xml
ffb6539
@BenAlvo1
Refactor DynamicFilterActionGroup to build custom state filters dynam…
f9a1ff9 
…ically and improve filter retrieval logic
@BenAlvo1
Introduce CustomStateFilter class to enhance filter functionality and…
a4d2541 
… streamline filter management
@BenAlvo1
Refactor CustomStateFilter and DynamicFilterActionGroup to improve fi…
5ca3e41 
…lter initialization and retrieval logic
@BenAlvo1
Simplify exception handling in DynamicFilterActionGroup to continue w…
362a262 
…ith default filters if custom states retrieval fails
@BenAlvo1
Enhance CustomResultState to implement Comparable and add valueOf met…
fa965c7 
…hod for improved filter management
@BenAlvo1
Add getFilterValue method to CustomResultState and Severity for impro…
9d2264b 
…ved filter integration
@BenAlvo1
Add refreshStates method to SastStateEnum and update refreshPanel to …
ffbf057 
…reset states
@BenAlvo1
Remove static reference to CustomState in ResultNode and clean up ref…
5f6ab7f 
…reshScanGroup method
@BenAlvo1
Remove unused import of ResultNode in BranchSelectionGroup
7aa8754
@BenAlvo1
Remove unused import of DynamicFilterActionGroup in ResultNode
abf47f2
@AlvoBen AlvoBen changed the title Feature/benalvo/add custom states Add Custom States Support (AST-83449, AST-83450) Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greensd4 greensd4 Awaiting requested review from greensd4 greensd4 is a code owner

@miryamfoiferCX miryamfoiferCX Awaiting requested review from miryamfoiferCX miryamfoiferCX is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvoBen @BenAlvo1