Skip to content

Conversation

@lgetwan
Copy link
Contributor

@lgetwan lgetwan commented Aug 22, 2025

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There was no DCD module

What is the new behavior?

  • There is a DCD module

Other information

There is no PUT endpoint in the REST API for the DCD, so it's not possible to update existing DCD connectors.

@lgetwan lgetwan requested a review from robin-checkmk as a code owner August 22, 2025 15:54
@lgetwan lgetwan marked this pull request as draft August 22, 2025 15:54
@lgetwan
Copy link
Contributor Author

lgetwan commented Aug 22, 2025

Next week, we'll get the integration tests running, as well. ;-)

@lgetwan lgetwan added enhancement New feature or request module:dcd This affects the dcd module. labels Aug 25, 2025
@lgetwan lgetwan marked this pull request as ready for review August 25, 2025 06:56
@lgetwan lgetwan self-assigned this Aug 25, 2025
description: Discover services on host creation.
type: bool
default: true
restrict_source_hosts:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation does not state, that this option is required, but the module fails without it.
I am torn between seeing this as an error, as it is technically a valid use case to not restrict source hosts, but the collection being stricter here, might help users avoid errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it "optional", but have set the default to an empty list, now.

@github-actions
Copy link

This pull request has been stale for 60 days. It will close in 7 days.

@github-actions github-actions bot added the stale Stale issues and pull requests. label Oct 29, 2025
@robin-checkmk robin-checkmk removed the stale Stale issues and pull requests. label Oct 29, 2025
@lgetwan
Copy link
Contributor Author

lgetwan commented Oct 29, 2025

We should trigger the integration tests...

@lgetwan
Copy link
Contributor Author

lgetwan commented Oct 30, 2025

@robin-checkmk
I cleaned up a lot.
Open topic is still the usage of "DCD" vs. "Dynamic Host Management"

Base automatically changed from feature/CheckmkAPI_changes to devel October 31, 2025 13:38
@lgetwan
Copy link
Contributor Author

lgetwan commented Nov 5, 2025

I added the parameter "matching_hosts", that I somehow forgot to implement before. :-p

The module looks complete from my point of view, now.

@robin-checkmk robin-checkmk merged commit c1a69ed into devel Nov 6, 2025
27 checks passed
@robin-checkmk robin-checkmk deleted the feature/dcd_module branch November 6, 2025 08:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request module:dcd This affects the dcd module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEED] Implement module for DCD Connections

3 participants