-
Notifications
You must be signed in to change notification settings - Fork 77
Add the DCD module donated by Atruvia AG #854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ch makes me write commit messages like this.
|
Next week, we'll get the integration tests running, as well. ;-) |
| description: Discover services on host creation. | ||
| type: bool | ||
| default: true | ||
| restrict_source_hosts: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation does not state, that this option is required, but the module fails without it.
I am torn between seeing this as an error, as it is technically a valid use case to not restrict source hosts, but the collection being stricter here, might help users avoid errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it "optional", but have set the default to an empty list, now.
|
This pull request has been stale for 60 days. It will close in 7 days. |
…ction-checkmk.general into feature/dcd_module
|
We should trigger the integration tests... |
|
@robin-checkmk |
…ction-checkmk.general into feature/dcd_module
|
I added the parameter "matching_hosts", that I somehow forgot to implement before. :-p The module looks complete from my point of view, now. |
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
There was no DCD module
What is the new behavior?
Other information
There is no PUT endpoint in the REST API for the DCD, so it's not possible to update existing DCD connectors.