Skip to content

Conversation

@phivo0
Copy link

@phivo0 phivo0 commented Nov 1, 2025

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Currently there is no option to specify a HTTP proxy for download the Checkmk Server Setup & GPG Key.

It is possible to specify the necessary environment variables that the play or role level, but this does not work if the remote nodes apt uses a network-local repository. In this the environment variables would overwrite apt's configuration forcing it to use the proxy. This results in a failure on the 'Update APT Cache.' task.

What is the new behavior?

Now there are new optional variables that allow the specification of http_proxy, https_proxy for downloading the Checkmk Server Setup & GPG Key. Both cases can be separtely configured if needed.

@phivo0 phivo0 requested a review from robin-checkmk as a code owner November 1, 2025 07:07
@github-actions
Copy link

github-actions bot commented Nov 1, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added documentation Improvements or additions to documentation role:server This affects the server role labels Nov 1, 2025
@phivo0
Copy link
Author

phivo0 commented Nov 1, 2025

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

@robin-checkmk robin-checkmk self-assigned this Nov 3, 2025
Copy link
Member

@robin-checkmk robin-checkmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks sensible apart from the minor bug mentioned in the dedicated comment. I am currently looking into adding a molecule test for the whole proxy topic, but that is more on the nice-to-have side of things. So as soon as the requested changes are implemented, we are good to merge.

@phivo0 phivo0 force-pushed the feature/server-http-proxy-vars branch from 800acbf to 7d86e2d Compare November 4, 2025 16:58
@robin-checkmk robin-checkmk merged commit 828766a into Checkmk:devel Nov 6, 2025
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation role:server This affects the server role

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants