Remove cluster collector resource constraints #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinhv
changed the title
|
After discussing it in detail and looking at best practices, I believe it makes more sense to not define any limits and requests, but rather leave that to the Kubernetes team. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In larger environments, we saw OOMKilled on the cluster collector showing that the limit of 200Mi is too low.
A higher CPU limit also does not hurt and can and should be adapted by the administrator themselves. Given the criticality of monitoring, one could even consider removing the limits entirely, but for good practice, I recommend leaving them in for now.