Next step 5. capture unroll coin state number at the appropriate time rather than hackily subtracting 1 #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a potentially unsafe subtraction that also was doing something sneaky. It was emulating the state number of channel handler before a mutating += 1 everywhere unroll coin's update was called. This captures it at the right time in each case so it doesn't need to subtract 1 when generating the curried unroll coin arguments and should be more durable. Ultimately it'd be nice to remove mutability from channel_handler, but I'm just getting a hold of that in referee, so it'll likely be much later.