Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next step 5. capture unroll coin state number at the appropriate time rather than hackily subtracting 1 #80

Open
wants to merge 2 commits into
base: active
Choose a base branch
from

Conversation

prozacchiwawa
Copy link
Collaborator

There was a potentially unsafe subtraction that also was doing something sneaky. It was emulating the state number of channel handler before a mutating += 1 everywhere unroll coin's update was called. This captures it at the right time in each case so it doesn't need to subtract 1 when generating the curried unroll coin arguments and should be more durable. Ultimately it'd be nice to remove mutability from channel_handler, but I'm just getting a hold of that in referee, so it'll likely be much later.

@prozacchiwawa prozacchiwawa changed the title 20250306 unroll coin state number capture unroll coin state number at the appropriate time rather than hackily subtracting 1 Mar 7, 2025
@prozacchiwawa prozacchiwawa changed the title capture unroll coin state number at the appropriate time rather than hackily subtracting 1 Step 5. capture unroll coin state number at the appropriate time rather than hackily subtracting 1 Mar 8, 2025
@prozacchiwawa prozacchiwawa changed the title Step 5. capture unroll coin state number at the appropriate time rather than hackily subtracting 1 Next step 5. capture unroll coin state number at the appropriate time rather than hackily subtracting 1 Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant