Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include warp green #78

Merged
merged 2 commits into from
Mar 29, 2024
Merged

include warp green #78

merged 2 commits into from
Mar 29, 2024

Conversation

BrandtH22
Copy link
Contributor

No description provided.

@hoffmang9
Copy link
Member

I think you need to add both repos and not just the group

@cmmarslender
Copy link
Contributor

I think you need to add both repos and not just the group

Yep this is correct. We don't really have a good guarantee that a group is always going to be just chia repos, so we made the decision originally to need specific repos listed

Co-authored-by: Starttoaster <[email protected]>
@Starttoaster Starttoaster merged commit d000719 into main Mar 29, 2024
6 checks passed
@Starttoaster Starttoaster deleted the include-warp-green branch March 29, 2024 20:41
@Starttoaster
Copy link
Contributor

Starttoaster commented Mar 30, 2024

I think you need to add both repos and not just the group

Yep this is correct. We don't really have a good guarantee that a group is always going to be just chia repos, so we made the decision originally to need specific repos listed

This is a done deed so not sure if anybody will read this comment, but this is actually somewhat untrue. You're right that we should use individual repositories for external projects for this reason, but you can actually list a whole github organization in the config file like we did for our public repos here: https://github.com/Chia-Network/ecosystem-activity/blob/main/config.yaml#L1

Was just going through my github notifications and read your response for the first time now 😄 Apologies for reviving dead threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants