pool: Improve transaction (#201) #219
Closed
+323
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for @ppolewicz suggestion. |
jianghushinian
force-pushed
the
improve-transaction
branch
2 times, most recently
from
11046d5 to
38b3bd9
Compare
jianghushinian
force-pushed
the
improve-transaction
branch
5 times, most recently
from
0ceaa9b to
187e5b0
Compare
jianghushinian
force-pushed
the
improve-transaction
branch
from
187e5b0 to
6d63286
Compare
|
Not needed as the entire payment system should be changed in production anyway |
|
I agree with jack. While this looks like a very good change, people might want to do things differently. Also, it does add more code to the reference. Thank you for the PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My general idea is to replace the old pending_payments queue with a database table(payment), to persist the data. make sure that afte the subtract the points, pending payment records still exists when the program exits unexpectedly, and the transaction failure retry can be achieved, finally moved confirm payment to a new task.