Replace UART with that from amaranth-soc RFC #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gatecat <[email protected]>
Signed-off-by: gatecat <[email protected]>
gatecat
force-pushed
the
replace-uart
branch
2 times, most recently
from
39743c6 to
d9b802c
Compare
robtaylor
reviewed
Mar 17, 2025
|
Doh. Yes all looks good to me! |
robtaylor
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See amaranth-lang/amaranth-soc#81
Still needs a unit test for the wrapper (which is a bit more complex than just taking that from the PR, because that PR doesn't include the PHY at all)