Improve directive with validation, events, and bug fixes#4
Open
Chitova263 wants to merge 2 commits into
Open
Conversation
added 2 commits
January 19, 2026 03:43
BREAKING CHANGE: Renamed `truncationCharacters` input to `truncationText` - Add `clamped` output event that emits truncation state - Add input validation with console warnings for invalid values - Fix precedence logic: `lines` now correctly takes precedence over `maxHeight` - Fix typo: `isTexFits` → `isTextFits` - Improve type safety: `getLastChild()` returns `ChildNode | null` - Add JSDoc documentation to public API - Update README with Outputs section
BREAKING CHANGE: Renamed `truncationCharacters` input to `truncationText`
Performance:
- Implement binary search for word truncation (O(log n) vs O(n))
- Cache line height to avoid repeated getComputedStyle calls
- Convert recursive DOM traversal to iterative approach
- Store and restore original content for correct re-clamping
Bug fixes:
- Fix precedence logic: `lines` now correctly takes precedence over `maxHeight`
- Add input validation with console warnings for invalid values
- Fix typo: `isTexFits` → `isTextFits`
- Improve type safety: `getLastChild()` returns `ChildNode | null`
Features:
- Add `clamped` output event that emits truncation state
- Add JSDoc documentation to public API
Testing:
- Add 17 unit tests covering initialization, clamping, validation,
input changes, precedence, nested content, and edge cases
- Add karma configuration for test runner
Demo:
- Create interactive demo app with configurable controls and live examples
- Add npm scripts: start, test, test:watch, build:demo
Chitova263
force-pushed
the
Improvements
branch
from
f749a59 to
4479406
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Renamed
truncationCharactersinput totruncationTextclampedoutput event that emits truncation statelinesnow correctly takes precedence overmaxHeightisTexFits→isTextFitsgetLastChild()returnsChildNode | null