Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simples fixes to 'Compile.ps1' Script #2971

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

og-mrk
Copy link
Contributor

@og-mrk og-mrk commented Oct 23, 2024

Type of Change

  • Bug fix

Description

Commit Summery:

  • 974c46c Save WinUtil's json strings with DOS-Style Newline Character (CRLF) instead of Unix-Style Newline Character (LF)
    Originated from PR Use here-strings for JSON in Compile.ps1 #2816 by @ruxunderscore
  • 5641623 Exit Early when facing Syntax Errors, Solves a problem when passing '-Run' Argument with 'Compile.ps1' Script - Use 'Out-Null' to follow common project conventions

Testing

Tested these changes when:

  1. Compiling without providing any extra arguments (Compile.ps1)
  2. Compiling with providing -Run Argument (Compile.ps1 -Run)
  3. Compiling with providing -Run -Arguments "-Debug" (Compile.ps1 -Run -Arguments "-Debug")
  4. Done the previous cases when no syntax errors are present and when there's syntax errors in WinUtil's code base.

All previous manual tests have passed successfully.

Impact

Won't have a major impact on end-user nor on contributors.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

…nstead of Unix-Style Newline Character (LF)

Originated from PR ChrisTitusTech#2816 by @ruxunderscore
…-Run' Argument with 'Compile.ps1' Script - Use 'Out-Null' to follow common project conventions
@og-mrk og-mrk marked this pull request as ready for review October 23, 2024 15:09
@ChrisTitusTech ChrisTitusTech merged commit c418fe9 into ChrisTitusTech:main Nov 7, 2024
1 check passed
@og-mrk og-mrk deleted the simple-fixes-2024-10-23 branch November 12, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants