This repository was archived by the owner on Jun 13, 2023. It is now read-only.
Integration Pt.1 - Redid all imports in every flight software file#177
Open
Integration Pt.1 - Redid all imports in every flight software file#177
Conversation
- Almost all files will show an edit, as basically every file was changed - VSCode decided to reformat in potentially damaging ways (redoing order of imports) so there may need to be a review on that change - Imports in general need a redo. There was a mix of relative and absolute, and while its somewhat fixed now the hack in main needs to be replaced
andrew032011
approved these changes
Mar 4, 2023
Contributor
andrew032011
left a comment
There was a problem hiding this comment.
This looks great! Thank you for completing this tedious task.
Something to think about...maybe for another ticket, @cameron-goddard? Part of the fixing of this repo will involve having a linter/standard for how we want to display import statements (i.e. alphabetical order, grouping the same modules together, etc.). That would make these refactoring changes a little easier in the future.
1 task
Author
|
Quick review seems to confirm that my over-aggressive formatter made no damaging changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses Jira ticket CISLUNAR-###
Testing
Notes
git pullshould pull both the simulator and the flight softwareComments
^ made no changes other than renaming of imports, therefore N/A