[Tan-8101] hide like/dislike btns in idea if reacting to inputs disabled#14251
Open
Stef-Rousset wants to merge 6 commits into
Open
[Tan-8101] hide like/dislike btns in idea if reacting to inputs disabled#14251Stef-Rousset wants to merge 6 commits into
Stef-Rousset wants to merge 6 commits into
Conversation
Stef-Rousset
force-pushed
the
TAN-8101-hide-like-btns-if-reacting-to-inputs-disabled
branch
from
7a4aa2d to
9a71222
Compare
Collaborator
|
IvaKop
reviewed
Jul 13, 2026
|
|
||
| cy.apiSignup(firstName, lastName, email, password); | ||
| cy.setLoginCookie(email, password); | ||
| cy.apiUpdatePhase({ |
Contributor
There was a problem hiding this comment.
I would suggest creating a new phase rather than updating an existing one. You would also not have to hard reload in this case.
Contributor
Author
There was a problem hiding this comment.
Hello Iva, thx for your review, I have applied your suggestion !
IvaKop
reviewed
Jul 13, 2026
IvaKop
left a comment
IvaKop
left a comment
Contributor
There was a problem hiding this comment.
Good job! Some small comments to address.
|
|
||
| describe('Reaction to input disabled', () => { | ||
| before(() => { | ||
| cy.apiUpdatePhase({ |
Contributor
There was a problem hiding this comment.
I would suggest creating a new phase rather than updating an existing one. You would also not have to hard reload in this case.
| const cancellingEnabled = reactingActionDescriptor.cancelling_enabled; | ||
| // hide like/dislike buttons if Reacting to inputs is disabled | ||
| // and idea is in active phase (disabled_reason equals reacting_disabled) | ||
| if (!reactingActionDescriptor.enabled && reactingActionDescriptor .disabled_reason === 'reacting_disabled') { |
Contributor
There was a problem hiding this comment.
In the context of a react component, if you want to return early and not render it, it is better to return null.
Stef-Rousset
force-pushed
the
TAN-8101-hide-like-btns-if-reacting-to-inputs-disabled
branch
from
9a71222 to
23a952e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Fixed
For translators