Skip to content

feat: Support custom clickhouse domain for otel collector #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
teeohhem merged 2 commits into from
May 22, 2025
Merged

feat: Support custom clickhouse domain for otel collector #12

teeohhem merged 2 commits into from
May 22, 2025

Conversation

@teeohhem
Copy link
Contributor

@teeohhem teeohhem commented May 22, 2025 •
edited
Loading

  • Adds setting in values.yml that allows users to specify a custom clickhouse domain for the otel collector instead of forcing them to use the clickhouse deployment in the chart.
  • Adds unit tests

Ref: HDX-1760

@teeohhem teeohhem requested a review from wrn14897 May 22, 2025 17:50
wrn14897
wrn14897 reviewed May 22, 2025
View reviewed changes
charts/hdx-oss-v2/tests/otel-collector-custom-clickhouse_test.yaml
set:
otel:
enabled: true
clickhouseEndpoint: "my-custom-clickhouse:9000"
Copy link
Collaborator

@wrn14897 wrn14897 May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: i know this is just for test. the endpoint needs a protocol specified like tcp://

@teeohhem teeohhem merged commit 155bb40 into main May 22, 2025
1 check passed
@teeohhem teeohhem deleted the tom/support-custom-ch branch May 22, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wrn14897 wrn14897 wrn14897 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@teeohhem @wrn14897