Skip to content

feat: support 'clickhouseUser' and 'clickhousePassword' values #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
teeohhem merged 5 commits into from
Jun 5, 2025
Merged

feat: support 'clickhouseUser' and 'clickhousePassword' values #26

teeohhem merged 5 commits into from
Jun 5, 2025

Conversation

@wrn14897
Copy link
Collaborator

@wrn14897 wrn14897 commented Jun 3, 2025 •
edited
Loading

Ref: HDX-1834

@teeohhem
Copy link
Contributor

teeohhem commented Jun 3, 2025

@wrn14897 this will also need to be updated: https://github.com/hyperdxio/helm-charts/blob/main/charts/hdx-oss-v2/data/users.xml#L45

@wrn14897
Copy link
Collaborator Author

wrn14897 commented Jun 3, 2025

@wrn14897 this will also need to be updated: main/charts/hdx-oss-v2/data/users.xml#L45

thanks for the reminder!

@wrn14897
Copy link
Collaborator Author

wrn14897 commented Jun 3, 2025

@wrn14897 this will also need to be updated: main/charts/hdx-oss-v2/data/users.xml#L45

@teeohhem the credential I added is for the external clickhouse instance. the users.xml is for the internal one. I assume its irrelevant.

@wrn14897 wrn14897 force-pushed the warren/allow-configuring-otelcol-credentials branch from a01fc8a to 16437a7 Compare June 3, 2025 16:39
@changeset-bot
Copy link

changeset-bot bot commented Jun 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 2f160cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
helm-charts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teeohhem
Copy link
Contributor

teeohhem commented Jun 3, 2025

@wrn14897 true, but if someone changes that value while deploying local clickhouse, it won't be in sync.

@teeohhem teeohhem self-requested a review June 4, 2025 15:11
teeohhem
teeohhem reviewed Jun 4, 2025
View reviewed changes
@wrn14897 wrn14897 force-pushed the warren/allow-configuring-otelcol-credentials branch from 54b3221 to 2f160cd Compare June 4, 2025 22:47
@teeohhem teeohhem self-requested a review June 5, 2025 02:52
@teeohhem teeohhem merged commit 4e246da into main Jun 5, 2025
1 of 3 checks passed
@teeohhem teeohhem deleted the warren/allow-configuring-otelcol-credentials branch June 5, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teeohhem teeohhem teeohhem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wrn14897 @teeohhem