Closed
Conversation
It happened when upgrading 25.10 to 25.12: ClickHouse/clickhouse-core-incidents#1479
There was a problem hiding this comment.
Pull request overview
Fixes a segfault observed during the 25.10 → 25.12 upgrade by hardening snapshot-related code paths against null snapshot pointers.
Changes:
- Prevent null dereference in fatal snapshot-sync error logging (
handle_snapshot_sync.cxx). - Prevent null dereference when compacting logs after snapshot completion (
handle_commit.cxx).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/handle_snapshot_sync.cxx |
Guards an error-log expression to avoid dereferencing a null snapshot pointer. |
src/handle_commit.cxx |
Adds a null check before using state_machine_->last_snapshot() during post-snapshot compaction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -722,7 +722,8 @@ void raft_server::on_snapshot_completed | |||
| ptr<snapshot> new_snp = state_machine_->last_snapshot(); | |||
| set_last_snapshot(new_snp); | |||
Comment on lines
+725
to
727
| if ( new_snp && | ||
| new_snp->get_last_log_idx() > | ||
| (ulong)params->reserved_log_items_ ) { |
Member
Author
|
Closing in favor of #96 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It happened when upgrading 25.10 to 25.12:
https://github.com/ClickHouse/clickhouse-core-incidents/issues/1479