test: minimal reproduction for inserting binary buffers into String/FixedString (#837)#861
Draft
Copilot wants to merge 2 commits into
Draft
test: minimal reproduction for inserting binary buffers into String/FixedString (#837)#861Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
|
|
Copilot created this pull request from a session on behalf of
peter-leonov-ch
June 18, 2026 19:01
View session
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a minimal reproduction test for #837: inserting raw binary
Bufferdata into aString/FixedStringcolumn viaJSONEachRow.JSONEachRowvalues are interpreted as UTF-8 text, so any byte>= 0x80is re-encoded into a multi-byte sequence — overflowing aFixedString(TOO_LARGE_STRING_SIZE) and silently corrupting aString.Tests live in
client-nodeonly; the behavior is not yet exercised for the Web client.FixedStringcase — asserts insert fails withTOO_LARGE_STRING_SIZE(0xF0→0xC3 0xB0overflowsFixedString(2)).Stringcase — asserts round-tripped bytes are corrupted (F0F0→C3B0C3B0).packages/client-node/__tests__/integration/node_insert_binary_string.test.ts.Checklist