Imaginator: add flag to by default inherit computed files, filters and triggers.#255
Open
narendraReddy45 wants to merge 7 commits into
Conversation
…itance of computed-files, filters, triggers
a97c8e0 to
7165c97
Compare
7165c97 to
3012d0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
This PR introduces
-enableDefaultInheritanceflag toimaginatorandbuilder-tool. When this flag is enabled, child images inherittriggers,filtersandcomputed-filesfrom sourceImage without need of empty.addfilesThis also maintains backward compatibility for existing image manifests functionality
Behavior matrix
Note: "metadata file" below refers to
filter,computed-filesortriggers-enableDefaultInheritanceFlag.addfile is presentChild has no metadata.
Child inherits metadata exactly as defined in base image.
Child has no metadata.
Child has no metadata.
Child uses its own metadata.
Child uses its own metadata.
.addfile existsChild appends rules to base metadata
Child appends rules to base metadata
Fixes #247
Type of Change
How Has This Been Tested?
Testing Approach
Build images using local imageserver, imaginator, builder-tool and verify files based on test cases for desired results
Checklist: