Refactor: python: Remove unnecessary metavar= settings. #3984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argparse will set metavar to the value of dest= by default. If dest= is not explictly set, then that value defaults to the same name as the first long option string. Thus in a lot of cases, we don't need to specify metavar.
Contributor
Author
|
Yes this is really nit-picky, but it came up while I was reviewing #3982 and less code is almost always better. |
nrwahl2
approved these changes
Nov 6, 2025
|
|
||
| parser.add_argument("-t", metavar="SUBAGENT", dest="subagent", | ||
| nargs=1, default="none", help="sub-agent") | ||
| parser.add_argument("-t", dest="subagent", nargs=1, default="none", |
Contributor
There was a problem hiding this comment.
I'm pretty sure nargs=1 could go away in all these too. You'd just need to treat the stored value as a string instead of as a list. Which would just mean dropping the normalize_options() function altogether. This can go in a later PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argparse will set metavar to the value of dest= by default. If dest= is not explictly set, then that value defaults to the same name as the first long option string. Thus in a lot of cases, we don't need to specify metavar.