mariadb: add SSL/TLS-Support #2045
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-2045/1/input |
oalbrigt
reviewed
May 12, 2025
oalbrigt
changed the title
|
retest this please |
oalbrigt
reviewed
May 22, 2025
heartbeat/mysql-common.sh
Outdated
| MYSQL_OPTIONS_LOCAL_SSL_OPTIONS="--ssl-mode=REQUIRED" | ||
| if [ "${OCF_RESOURCE_TYPE}" = "mariadb" ] ; then | ||
| MYSQL_OPTIONS_LOCAL_SSL_OPTIONS="--ssl" | ||
| if [ -n "${$OCF_RESKEY_replication_master_ssl_ca}" ] ; then |
There was a problem hiding this comment.
CI fails due to double-$ used here. You should only use ${OCF_RESKEY_<name>} without the inner $ you've added by mistake here.
oalbrigt
reviewed
May 22, 2025
|
Can one of the admins check and authorise this run please: https://ci.kronosnet.org/job/resource-agents/job/resource-agents-pipeline/job/PR-2045/3/input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed SSL-Support for a new mariadb-HA-Cluster. Adopted the needed Parameters from mysql RA to keep migration between those too as easy as possible.