Improve support for Blender 2.93 LTS #32
Conversation
io_scene_cod/export_xmodel.py
Outdated
|
|
||
| alpha_default = 1.0 | ||
|
|
||
| # mesh.calc_tessface() # Is this needed? | ||
| # mesh.calc_loop_triangles() # Is this needed? |
There was a problem hiding this comment.
The call likely ensures that the data will be up-to-date. I think it should be uncommented.
There was a problem hiding this comment.
calc_loop_triangles() is called earlier in the mesh_triangulate function (line 39). And it doesn't seem like the mesh is modified in any way between mesh_triangulate and this commented out line.
There was a problem hiding this comment.
In that case the comment could be removed.
There was a problem hiding this comment.
Yup, already done:
https://github.com/CoDEmanX/blender-cod/pull/32/files#diff-6580964a45e40f7fbc9076d04d07f7ebc3bc57206acb8c37703fafdb131e4edeL261
This PR is pretty much ready to merge. Some testing of the vertex colors feature would be nice but I don't have a model to test with. I actually just started using Blender, so I'm a noob when it comes to actually making models. 😅
|
I have tested this PR with a test model that I made and it successfully exports to .XMODEL_EXPORT format without error and it successfully loads into the CoD WaW Mod Tools (Asset Manager/Viewer). |
|
My test model only had a color map (image texture), no spec maps or bump maps or anything like that. |
Closes #31
Closes #33
Closes #35