Improve stubs for multi-platform usage#25
Merged
GuillaumeLagrange merged 3 commits intomainfrom Apr 16, 2026
Merged
Conversation
GuillaumeLagrange
force-pushed
the
macos
branch
11 times, most recently
from
40e060d to
4376be3
Compare
not-matthias
requested changes
Apr 14, 2026
For real this time_final_final_v2.
GuillaumeLagrange
force-pushed
the
macos
branch
3 times, most recently
from
7dddb20 to
7fca46b
Compare
Use `c_char` (signed on macOS) instead of `u8` for all FFI string parameters in c.zig, and change the public InstrumentHooks type to an opaque struct so the header and generated core.c agree on the type layout. The release script now post-processes Zig's mangled struct names into stable `struct InstrumentHooks`. Also fixes CMakeLists using CMAKE_CXX_COMPILER_ID for a C-only project and removes the release dependency from example build targets. Co-Authored-By: Claude <noreply@anthropic.com>
This is a band-aid, the real long term solution is to actually have a part of the zig code transpiled to c and usable on macos rather than just stubs.
GuillaumeLagrange
force-pushed
the
macos
branch
from
7fca46b to
ecdf31a
Compare
not-matthias
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To merge before these