Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change or remove packages. Change all git-ssh to https #1978

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change or remove packages. Change all git-ssh to https #1978

wants to merge 2 commits into from

Conversation

thejsj
Copy link
Member

@thejsj thejsj commented May 2, 2017 •
edited
Loading

What this PR does

  • Remove all private git+ssh dependencies and moves them to private npm modules
  • Removes all private git+ssh dependences and moves them to https
  • This removes the need to have an id_rsa in the build

Integration Test

Please follow the guidelines presented in the How to Test an API PR
article when setting-up and performing tests.

  • Integration Tested @ commitsh by person_3 on (gamma|epsilon|staging)

Nathan219
Nathan219 requested changes May 18, 2017
View reviewed changes
package.json
@@ -105,16 +104,16 @@
"xtend": "3.0.0"
},
"devDependencies": {
"@runnable/navi-entry": "4.0.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it even a dep?

@anandkumarpatel
Copy link
Contributor

@thejsj can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nathan219 Nathan219 Nathan219 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thejsj @anandkumarpatel @Nathan219