fixed xss vulnerability #686
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 11, 2022 18:58
|
Will this be merged ? |
|
Looks good, please merge. |
chris-tuncap
approved these changes
May 31, 2022
IDiazAsurion
approved these changes
May 31, 2022
|
Hi. Is there a release for this yet? I still see latest is 2.1.4 in npm and it does not have the fix. |
No one seems to be active in merging PRs around here. My team has moved on to using sweetalert2 to avoid the xss vulnerability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Severe XSS vulnerability was discovered. More here https://security.snyk.io/vuln/SNYK-JS-TOASTR-2396430.
Probably need to release it with incremented major version.
Changed origin branch from master to develop as discussed here #684