Manchester | 26-ITP-Jan | Liban Jama | Sprint 1 | Data Groups by libanj0161 · Pull Request #1016 · CodeYourFuture/Module-Data-Groups

libanj0161 · 2026-03-16T12:55:53Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed Fix under data groups module.

Questions

N/A.

…-fix

cjyuan · 2026-03-19T14:26:31Z

Sprint-1/fix/median.js

+  let numbers = [];
+
+  // loop over each item in list.
+  for (const item of list) {
+    // if item is a number, push it into the numbers array.
+    if (typeof item === "number") {
+      numbers.push(item);
+    }
+  }


Could consider using array's .filter() method to simplify the code on lines 15-23.

Do you plan to consider -Infinity, Infinity, and NaN in the median calculation (and also in the functions in implement/max.js and implement/sum.js)?

cjyuan · 2026-03-19T14:28:28Z

Sprint-1/implement/dedupe.test.js

 // Given an array with no duplicates
 // When passed to the dedupe function
 // Then it should return a copy of the original array

 // Given an array with strings or numbers
 // When passed to the dedupe function
 // Then it should remove the duplicate values, preserving the first occurence of each element


There are two more tests to be implemented on this file.

cjyuan · 2026-03-19T14:29:19Z

Sprint-1/implement/max.test.js

+test("given an array with non-number values, returns the max and ignore non-numeric values", () => {
+  expect(findMax([3, "dogs", 1, "cat", null])).toBe(3);
+});
+
 // Given an array with only non-number values
 // When passed to the max function
 // Then it should return the least surprising value given how it behaves for all other inputs
+
+test("given an array with only non-number values, returns -Infinity", () => {
+  expect(findMax(["a", null, true, undefined])).toBe(-Infinity);
+});


When a string representing a valid numeric literal (for example, "300") is compared to a number,
JavaScript first converts the string into its numeric equivalent before performing the comparison.
As a result, the expression 20 < "300" evaluates to true.

To test if the function can correctly ignore non-numeric values,
consider including a string such as "300" in the relevant test cases.

completed median sprint 1

152abe7

libanj0161 added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 16, 2026

completed implement

7bc29b0

libanj0161 added the Module-Data-Groups The name of the module. label Mar 16, 2026