West Midlands | 25-ITP-Sep | Baba Yusuf | Sprint 3 | Reading List #901
Conversation
Baba05206
added
📅 Sprint 3
JaypeeLan
added
Review in progress
JaypeeLan
left a comment
JaypeeLan
left a comment
There was a problem hiding this comment.
Good job. Everything works well, but I think the UI can be better. Black text on red/green background does not seem too ideal. Also maybe use an ordered list? the size of each card should be reduced, so I don't need to scroll.
JaypeeLan
added
Reviewed
| function readingList() { | ||
| const unorderedList = document.querySelector("#reading-list"); | ||
|
|
||
| for (const book of books) { |
There was a problem hiding this comment.
Make a base condition, if book is empty, so your application does not crash.
There was a problem hiding this comment.
Many thanks @JaypeeLan. I have now updated the script to check if the books variable is null or undefined, or if the array is empty. Will return message telling the user their reading list is empty
There was a problem hiding this comment.
@Baba05206 Please go through the conversations, I made a comment regarding the design.
Baba05206
added
the
Needs Review
…t and color scheme.
|
My apologies, I missed the first comment. I have now adjusted the colour scheme on the page |
2 participants
Learners, PR Template
Self checklist
Changelist
Updated index.html, style.css, style.js and style.test.js files in order to complete the task
Ran the test to ensure all three tests passed
I was struggling with testing 'background color changes depending on whether book has been read' and so updated the test to expect class instead of background color.
Questions