London | ITP-SEP-25 | Samuel Tarawally | Sprint 2 | Coursework/sprint 2 #925
+283
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarawally
added
the
Needs Review
Contributor
|
Changes look good. |
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR completes the Sprint 2 coursework and addresses all feedback from the previous review.
Key Changes:
contains: Now handles arrays correctly by checking thelengthproperty.createLookup: Refactored to use array destructuring for cleaner code.parseQueryString: Added support for URL decoding and improved handling of keys without values.tally: UsedObject.create(null)to prevent prototype collisions.debug/address.js,debug/author.js,debug/recipe.js, andinterpret/invert.js.Note: This replaces PR #894, which was closed to resolve a git history issue.
Questions
No specific questions for the reviewer at this time.