London | 25-ITP-Sep | Zadri Abdule | Sprint 2 | Coursework #867

Zadri415 · 2025-11-10T17:22:25Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Briefly explain your PR.
Completed all of the tasks for Sprint 2.
Ask any questions you have for your reviewer.
Not at the moment.

…ey-errors/1.js)

…rors/2.js)

… place

…values

github-actions · 2025-11-10T17:22:43Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-10T17:27:53Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-10T19:47:19Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-10T19:47:32Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-10T20:57:20Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-11T00:34:32Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-12T14:42:16Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-12T14:42:21Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

LonMcGregor

Good work on this sprint. I have left some comments throughout in places where you might need to have another look.

LonMcGregor · 2025-11-12T14:44:21Z

Sprint-2/2-mandatory-debug/0.js

+      return a * b; 
+}
+
+console.log(` The sum of 10 and 32 is ${sum(10, 32)}`);


Here, I think the function inside the ${} has the wrong name, so this will give an error

LonMcGregor · 2025-11-12T14:47:46Z

Sprint-2/3-mandatory-implement/2-cases.js

 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+const greeting = "Hello there."
+
+console.log(greeting.toUpperCase());


This approach will work, but this task asks you to create a function. Can you create a named function that takes a string and returns it in uppercase?

Making a named function is important as it makes it easier to test code than using console.log()s

Sprint-2/3-mandatory-implement/3-to-pounds.js

LonMcGregor · 2025-11-12T14:52:26Z

Sprint-2/5-stretch-extend/format-time.js

+
+// The function ignores the minutes and did'not handle midnight (00:00) or noon (12:00) properly. 
+ // Better version:
+ function formatAs12HourClock(time) {


Good work attempting this stretch task!

If we look at your tests, you try 08:00 which gets returned as 08:00 am, and trying 13:00 gives you 1:00 pm. There seems to be a difference in how am/pm handle leading 0s. Can you find why that happens?

github-actions · 2025-11-12T14:53:59Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-12T14:54:14Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Zadri415 added 12 commits November 8, 2025 21:20

Interpret error message and explain cause in 1-key-errors/0.js

0fc35ed

Fix and explain redeclaration SyntaxError in convertToPercentage (1-k…

f4e38d3

…ey-errors/1.js)

Fix and explain 'unexpected number' SyntaxError in square() (1-key-er…

8a162e3

…rors/2.js)

Fix undefined return in sum() and explain cause (2-mandatory-debug/0.js

2bf3487

add changes to 2-mandatory-debug/0.js

54ca144

add prediction and explanation

ff14721

predict the output

97dc683

add and explain calculateBMI() function to compute BMI to one decimal…

2f8d74e

… place

add using String.toUpperCase() to convert greeting to uppercase

c52e087

turn interpret/to-pounds.js into a reuseable block of code

0de1e19

add formatTimeDisplay() answers explaining pad() calls and returning …

a451eda

…values

add and test formatAs12HourClock function with passing assertions

083a9d2

Zadri415 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 10, 2025

LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 12, 2025

LonMcGregor reviewed Nov 12, 2025

View reviewed changes

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 12, 2025

Fix console log to use multiply function

f4c8d85

Fix typo in function name from forma to format

2776d16

Uh oh!

London | 25-ITP-Sep | Zadri Abdule | Sprint 2 | Coursework #867

Are you sure you want to change the base?

London | 25-ITP-Sep | Zadri Abdule | Sprint 2 | Coursework #867

Uh oh!

Conversation

Zadri415 commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Uh oh!

github-actions bot commented Nov 10, 2025

Uh oh!

github-actions bot commented Nov 10, 2025

Uh oh!

github-actions bot commented Nov 10, 2025

Uh oh!

github-actions bot commented Nov 10, 2025

Uh oh!

github-actions bot commented Nov 10, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

LonMcGregor Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

LonMcGregor Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LonMcGregor Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Zadri415 commented Nov 10, 2025 •

edited

Loading