Sheffield | 25-ITP-SEP | Declan Williams | Sprint 3 | Coursework #878

CatchingKiyoko · 2025-11-13T17:40:48Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

refactored and added lines of code
answered questions in comments

…ction

…add corresponding test case

…d corresponding test case

…CardValue function with comments explaining function and updated tests

…ction and add corresponding test cases

…alid card ranks

…alue function

…tion

…d by making sure they always end in "th"

…al suffixes

…test for special ordinal numbers

…omments detailing.

cjyuan

Code is pretty solid.
You missed implementing the Jest tests in Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest.

cjyuan · 2025-11-15T02:48:05Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

 function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
-    return true;
-  }
+    if (numerator < denominator) return true;
+    else return false;
 }


According to the definition of proper fraction in mathematics:

isProperFraction(-4, 3) should return false

isProperFraction(-2, 5) should return true

isProperFraction(-2, 0) should return false

isProperFraction(-1, 1) should return false

isProperFraction(-2, -3) should return true

Can you look up the definition of proper fraction and update your function accordingly?

cjyuan · 2025-11-15T02:49:45Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

-  if (rank === "A") {
-    return 11;
-  }
+    var rank = card.slice(0, -1); // get the rank of the card by removing the last character. (the suit is the last character)


Why not use let to declare the variable?

cjyuan · 2025-11-15T02:51:35Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+    if (rank === "A") return 11; // this checks for Aces
+    // Handle Number Cards (2-9)
+    if (rank === "2") return 2; // this checks for the twos
+    if (rank === "3") return 3; // this checks for the threes
+    if (rank === "4") return 4; // this checks for the fours
+    if (rank === "5") return 5; // this should check for fives
+    if (rank === "6") return 6; // this checks for the sixes
+    if (rank === "7") return 7; // this checks for the sevens
+    if (rank === "8") return 8; // this checks for the eights
+    if (rank === "9") return 9; // this checks for the nines
+    // Handle Face Cards (J, Q, K) And 10's
+    if (rank === "J") return 10; // this checks for Jacks
+    if (rank === "Q") return 10; // this checks for Queens
+    if (rank === "K") return 10; // this checks for Kings
+    if (rank === "10") return 10; // this checks for Tens
+    // if none of the above its an invalid card and throw an error


This is very solid. As a stretch exercise, can you figure out a way to simplify these code (e.g., reduce the number of if statements involved)?

by mapping each of the card ranks directly to values so instead of using if statements and using an object to make it more scalable and cleaner.

by mapping each of the card ranks directly to values so instead of using if statements and using an object to make it more scalable and cleaner.

How would you express them in JS? And what do you mean by "scalable"?

by making a lookup object by making a const of the card values and then using the key to pull each of the ranks and this would make it have no if-statements. and its more scalable in the sence of if needing to add cards

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

cjyuan · 2025-11-15T02:56:35Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

+// Case 2: Identify the ordinal number for 2
+// When the number is 2,
+// The function should then return "2nd".
+
+test("Should return `2nd` for 2", () => {
+    expect(getOrdinalNumber(2)).toEqual("2nd");
+});
+
+// Case 3: Identify the ordinal number for 3
+// When the number is 3,
+// The Function should the return "3rd"
+
+test("Should return `3rd` for 3", () => {
+    expect(getOrdinalNumber(3)).toEqual("3rd");
+});


To ensure thorough testing, we need broad scenarios that cover all possible cases.
Listing individual values, however, can quickly lead to an unmanageable number of test cases.
Instead of writing tests for individual numbers, consider grouping all possible input values into meaningful categories.
Then, select representative samples from each category to test. This approach improves coverage and makes our tests easier to maintain.

For example, we can prepare a test for numbers 2, 22, 132, etc. as

test("append 'nd' to numbers ending in 2, except those ending in 12", () => { expect( getOrdinalNumber(2) ).toEqual("2nd"); expect( getOrdinalNumber(22) ).toEqual("22nd"); expect( getOrdinalNumber(132) ).toEqual("132nd"); });

Can you update the tests in this script to make them more comprehensive? That is, create few test categories that can cover all possible cases?

have updated them to have more tests to cover more possible cases

…tead of throwing an error

…ardValue function

…ction

…cases and improve formatting

cjyuan · 2025-11-15T12:53:30Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

+  if (denominator === 0) return false; // avoid division by zero
+  return Math.abs(numerator) < Math.abs(denominator);


There is no "division by zero" needs to be prevented though.

Will the function still work equally well without this if statement?

yes it would still work because it would return false implicitly with out the if-statement, as im currently explicitly looking for the error having the if-statement in.

cjyuan · 2025-11-15T12:56:12Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+    if (rank === "A") return 11; // this checks for Aces
+    // Handle Number Cards (2-9)
+    if (rank === "2") return 2; // this checks for the twos
+    if (rank === "3") return 3; // this checks for the threes
+    if (rank === "4") return 4; // this checks for the fours
+    if (rank === "5") return 5; // this should check for fives
+    if (rank === "6") return 6; // this checks for the sixes
+    if (rank === "7") return 7; // this checks for the sevens
+    if (rank === "8") return 8; // this checks for the eights
+    if (rank === "9") return 9; // this checks for the nines
+    // Handle Face Cards (J, Q, K) And 10's
+    if (rank === "J") return 10; // this checks for Jacks
+    if (rank === "Q") return 10; // this checks for Queens
+    if (rank === "K") return 10; // this checks for Kings
+    if (rank === "10") return 10; // this checks for Tens
+    // if none of the above its an invalid card and throw an error


by mapping each of the card ranks directly to values so instead of using if statements and using an object to make it more scalable and cleaner.

How would you express them in JS? And what do you mean by "scalable"?

cjyuan · 2025-11-15T13:02:56Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+test("should return true for a negative proper fraction", () => {
+  expect(isproperFraction(-4, 7)).toEqual(true);
+});


Could consider introduce a test for negative improper fraction to make the test more complete.

have implemented the test for negative improper fractions.

Added test cases for negative improper fractions.

cjyuan · 2025-11-19T13:17:18Z

Looks good. Well done.

CatchingKiyoko added 19 commits November 1, 2025 13:48

implemented acute and obtuse angle identification in getAngleType fun…

32eef26

…ction

Implement straight angle identification in getAngleType function and …

0709cbe

…add corresponding test case

fixed if statement for obtuse angle

def5669

Implement reflex angle identification in getAngleType function and ad…

487694e

…d corresponding test case

fix: add missing assertions for negative and equal fraction checks

5fb6f95

Implement card value retrieval for face cards and number cards in get…

876b8a1

…CardValue function with comments explaining function and updated tests

Implement numerical value retrieval for cards 2-9 in getCardValue fun…

801d5d8

…ction and add corresponding test cases

Enhance getCardValue function comments and add error handling for inv…

7e6166b

…alid card ranks

Fix typo in error message assertion for invalid card rank in getCardV…

dbf085f

…alue function

refactor: implement character counting logic in countChar function

a09a992

add test for handling no occurrences of a character in countChar func…

5f2aa2c

…tion

implemented how special ordinal number cases like 11,12,13 are handle…

22f8e4a

…d by making sure they always end in "th"

refactor: implement getOrdinalNumber function to return correct ordin…

f3f8b47

…al suffixes

implented tests for ordinal numbers 2nd and 3rd

f08ec15

test: update test descriptions for ordinal numbers and implemented a …

234e8b6

…test for special ordinal numbers

implemented repeat function with error handling and edge cases with c…

6a021e3

…omments detailing.

test: add test case for returning original string when count is 1

7455253

test: add test case for returning original string when count is 0

5e1196f

test: add test case for returning original string when count is negative

cc80d7e

CatchingKiyoko added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Nov 13, 2025

cjyuan reviewed Nov 15, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 15, 2025

CatchingKiyoko added 5 commits November 15, 2025 10:49

implemented the cases of jest tests for each of the angles

ca08ca9

fix: update isProperFraction function logic and add missing assertion

7dc44ec

fix: update isProperFraction to return false for zero denominator ins…

5e720c8

…tead of throwing an error

added "module.exports" so jest can find the function

252bfb9

implmented jest tests for each of the cases

3b7e322

CatchingKiyoko added 5 commits November 15, 2025 11:46

fixed equal numerator and denominator jest test

809e11b

added module.exports

0b2a485

fix: clean up formatting and ensure consistent error handling in getC…

377b7db

…ardValue function

fix: correct ordinal suffix for special cases in getOrdinalNumber fun…

096d45c

…ction

fix: enhance tests for getOrdinalNumber function to cover additional …

1200ba7

…cases and improve formatting

CatchingKiyoko added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 15, 2025

cjyuan reviewed Nov 15, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 15, 2025

Enhance tests for proper fraction validation

014b90e

Added test cases for negative improper fractions.

CatchingKiyoko added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 19, 2025

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 19, 2025

CatchingKiyoko mentioned this pull request Nov 22, 2025

25-ITP-SEP | Structuring and Testing Data | declan williams CatchingKiyoko/My-Coursework-Planner#41

Open

		if (denominator === 0) return false; // avoid division by zero
		return Math.abs(numerator) < Math.abs(denominator);

Uh oh!

Sheffield | 25-ITP-SEP | Declan Williams | Sprint 3 | Coursework #878

Are you sure you want to change the base?

Sheffield | 25-ITP-SEP | Declan Williams | Sprint 3 | Coursework #878

Uh oh!

Conversation

CatchingKiyoko commented Nov 13, 2025

Learners, PR Template

Changelist

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cjyuan Nov 15, 2025 •

edited

Loading

cjyuan Nov 15, 2025 •

edited

Loading