Skip to content

Conversation

@Konvaly
Copy link

@Konvaly Konvaly commented Nov 20, 2025

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
This PR covers work in the Test-First Development section of the sprint project:

Test-First Approach:

Wrote Jest tests before implementing the functions, practicing the test-driven development (TDD) process.

Jest Tests: Created and completed test files for:

count.test.js
repeat-str.test.js
get-ordinal-number.test.js
Each test file follows the provided acceptance criteria and uses Jest’s syntax for clarity.

Functions were then implemented to make all tests pass.

All tests run successfully with the VS Code Test Runner or by using npm test.

@Konvaly Konvaly added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 20, 2025
@wheresdiasd wheresdiasd added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 20, 2025
Copy link

@iprithv iprithv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Konvaly
Copy link
Author

Konvaly commented Nov 22, 2025

Hi @iprithv !

Thank you for your approval!
Could you kindly review my PR and set the label "Complete" if everything is fine and meet the requirements of the task, please?

@wheresdiasd wheresdiasd added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 24, 2025
@Konvaly
Copy link
Author

Konvaly commented Nov 24, 2025

@wheresdiasd @iprithv thank you for your time and consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants