West Midlands | ITP - SEPT | Jonathan Boahene | Sprint 3 |Practice TDD #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abayie
added
the
Needs Review
cjyuan
reviewed
Nov 24, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you keep this branch clean so that it only contains changed files in the 2-practice-tdd subfolder?
cjyuan
added
Reviewed
Abayie
force-pushed
the
coursework/sprint-3-practice-tdd
branch
from
226c0e8 to
a7455e9
Compare
Abayie
added
the
Needs Review
cjyuan
reviewed
Nov 24, 2025
| }); | ||
|
|
||
| //All other numbers => th | ||
| test("append 'th' to all other numbers", () => { |
Contributor
There was a problem hiding this comment.
"numbers ending in 0, 4-9" is probably clearer than "all other numbers".
Contributor
There was a problem hiding this comment.
Test categories are comprehensives.
Could test more samples in each category.
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Practice tdd test sprint 3
Questions
No questions