Skip to content

Fix warning for rfc/deprecate-implicitly-nullable-types and Add php version 8.2 ~ 8.4 to strategy matrix #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nukisashineko
Copy link

@nukisashineko nukisashineko commented Jan 26, 2025

for https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

before:

~/work/Specify$ docker run --rm --interactive --tty --volume $PWD:/app --workdir /app php:8.4-cli vendor/bin/phpunit -c ./phpunit.xml

Deprecated: Codeception\Specify::specify(): Implicitly marking parameter $code as nullable is deprecated, the explicit nullable type must be used instead in /app/src/Codeception/Specify.php on line 20

Deprecated: Codeception\Specify::describe(): Implicitly marking parameter $code as nullable is deprecated, the explicit nullable type must be used instead in /app/src/Codeception/Specify.php on line 30

Deprecated: Codeception\Specify::it(): Implicitly marking parameter $code as nullable is deprecated, the explicit nullable type must be used instead in /app/src/Codeception/Specify.php on line 40

Deprecated: Codeception\Specify::its(): Implicitly marking parameter $code as nullable is deprecated, the explicit nullable type must be used instead in /app/src/Codeception/Specify.php on line 51

Deprecated: Codeception\Specify::should(): Implicitly marking parameter $code as nullable is deprecated, the explicit nullable type must be used instead in /app/src/Codeception/Specify.php on line 56

Deprecated: Codeception\Specify::shouldNot(): Implicitly marking parameter $code as nullable is deprecated, the explicit nullable type must be used instead in /app/src/Codeception/Specify.php on line 67

Deprecated: Codeception\Specify\SpecifyHooks::runSpec(): Implicitly marking parameter $callable as nullable is deprecated, the explicit nullable type must be used instead in /app/src/Codeception/Specify/SpecifyHooks.php on line 38

Deprecated: Codeception\Specify\SpecifyHooks::beforeSpecify(): Implicitly marking parameter $callable as nullable is deprecated, the explicit nullable type must be used instead in /app/src/Codeception/Specify/SpecifyHooks.php on line 207

Deprecated: Codeception\Specify\SpecifyHooks::afterSpecify(): Implicitly marking parameter $callable as nullable is deprecated, the explicit nullable type must be used instead in /app/src/Codeception/Specify/SpecifyHooks.php on line 212
PHPUnit 9.6.22 by Sebastian Bergmann and contributors.

..
Deprecated: Codeception\Specify\SpecifyTest::run(): Implicitly marking parameter $result as nullable is deprecated, the explicit nullable type must be used instead in /app/src/Codeception/Specify/SpecifyTest.php on line 68
I...................

Time: 00:00.038, Memory: 8.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 22, Assertions: 67, Incomplete: 1.

after

~/work/Specify$ docker run --rm --interactive --tty --volume $PWD:/app --workdir /app php:8.4-cli vendor/bin/phpunit -c ./phpunit.xml
PHPUnit 9.6.22 by Sebastian Bergmann and contributors.

..I...................

Time: 00:00.039, Memory: 8.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 22, Assertions: 67, Incomplete: 1.

@nukisashineko nukisashineko force-pushed the feature_suppert_version_8_4 branch from caec940 to 4a97b83 Compare January 26, 2025 05:42
@nukisashineko nukisashineko changed the title add php version 8.2 ~ 8.4 to strategy matrix Fix warning for rfc/deprecate-implicitly-nullable-types and Add php version 8.2 ~ 8.4 to strategy matrix Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant