Skip to content

fix: unblock Dependabot by aligning phpcs coding-standards deps #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
selul merged 4 commits into from
Aug 4, 2026
Merged

fix: unblock Dependabot by aligning phpcs coding-standards deps #1107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bada66
fix: modernize phpcs coding-standards deps to unblock Dependabot
selul Aug 4, 2026
deb514b
fix: correct @param docblock flagged by updated phpcs standard
selul Aug 4, 2026
8e7d17b
fix: type update_timeline param as mixed[] and drop stale phpstan bas…
selul Aug 4, 2026
b68178e
fix: type update_timeline $new_events as mixed to keep is_array() mea…
selul Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
},
"require-dev": {
"wp-coding-standards/wpcs": "^2.3",
"dealerdirect/phpcodesniffer-composer-installer": "^0.7.2",
"dealerdirect/phpcodesniffer-composer-installer": "^1.0",
"phpunit/phpunit": "9.*",
"yoast/phpunit-polyfills": "^2.0",
"codeinwp/phpcs-ruleset": "dev-main",
Expand Down
161 changes: 94 additions & 67 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions includes/admin/models/class-rop-scheduler-model.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,8 +535,8 @@ private function get_week_start( $start = 0 ) {
/**
* Update the events timeline.
*
* @param $new_events $new_events New events timeline.
* @param string $account_id account id.
* @param mixed $new_events New events timeline.
* @param string $account_id account id.
*
* @return bool Success or not.
*/
Expand Down
6 changes: 0 additions & 6 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3078,12 +3078,6 @@ parameters:
count: 1
path: includes/admin/models/class-rop-scheduler-model.php

-
message: '#^Method Rop_Scheduler_Model\:\:update_timeline\(\) has parameter \$new_events with no type specified\.$#'
identifier: missingType.parameter
count: 1
path: includes/admin/models/class-rop-scheduler-model.php

-
message: '#^PHPDoc tag @SuppressWarnings has invalid value \(\(PHPMD\.UnusedLocalVariable\)\)\: Unexpected token "\.UnusedLocalVariable\)", expected ''\)'' at offset 89 on line 4$#'
identifier: phpDoc.parseError
Expand Down
Loading