Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nix flake example #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

transgirllucy
Copy link
Contributor

@transgirllucy transgirllucy commented Feb 23, 2025

Notice

  • I understand the code that I have edited, and have the means
    to test it before making changes to Concord.

What?

Why?

How?

Testing?

Screenshots

Anything Else?

Copy link
Collaborator

@HackerSmacker HackerSmacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have placed a comment that's merely a minor nitpick.

@@ -169,6 +169,55 @@ Alternatively, you can use an AUR helper:
yay -S concord-git
```

#### Lix/Nix/Nixos
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might would write it as NixOS/Nix/Lix based on the prevalence of the choices listed

Comment on lines +196 to +200
installPhase = ''
mkdir -pv $out/usr/local
mkdir -pv $out/usr/share
make install PREFIX="$out/usr/local" SHAREDIR="$out/usr/share"
'';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabs and spaces?

@HackerSmacker
Copy link
Collaborator

Followup question -- why is this pinned to a single commit hash in the dev branch? Who wants to update that on every commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants