Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONAME support #193

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

SONAME support #193

wants to merge 1 commit into from

Conversation

HackerSmacker
Copy link
Collaborator

Notice

  • [ X] I understand the code that I have edited, and have the means
    to test it before making changes to Concord.

What?

This is an exploratory PR response to a request made by Souji Thenria, who requested SONAME support.

Why?

As we make breaking changes, it will become necessary to have a proper SONAME versioning system of sorts.

How?

For Concord 2.3.0, the SONAME is libdiscord.so.MAJOR.MINOR, where MAJOR is 2.3, and MINOR is 1 (in this, I have rolled over the VERSION in src/Makefile to 2.3.1, in anticipation of another release).

Testing?

I tested this on:

  • GNU/Linux (GCC, GNU ld)
  • FreeBSD (LLVM, LLD)
  • Solaris (GCC, GNU ld)

Anything Else?

At some point, it will become necessary to write a new versioning policy, or change that which I have already specified in this PR.

@HackerSmacker HackerSmacker changed the base branch from master to dev February 28, 2025 22:58
@SoujiThenria
Copy link
Contributor

First of all thank you!

I noticed two issues:

  1. When running make uninstall the shared library file is not removed, since the uninstall target only removes libdiscord.so.
  2. A symbolic link for libdiscord.so pointing to the ABI versioned file (e.g. libdiscord.so.2.3.1) is missing, causing -ldiscord to not be found when linking against Concord.

@HackerSmacker
Copy link
Collaborator Author

Oops, I legitimately thought I had the ln command in there, I'll fix it in a bit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants