Fix welcome workflow triggering for returning contributors.#15355
Open
Darshan-upadhyay1110 wants to merge 1 commit intomainfrom
Open
Fix welcome workflow triggering for returning contributors.#15355Darshan-upadhyay1110 wants to merge 1 commit intomainfrom
Darshan-upadhyay1110 wants to merge 1 commit intomainfrom
Conversation
Darshan-upadhyay1110
force-pushed
the
private/darshan/correction-in-welcome-workflow
branch
2 times, most recently
from
2ebe20e to
dec019a
Compare
The welcome message was posted on every PR from non-members because the author_association check treated NONE (no repo role) as a new contributor. Replace it with a PR count search so only genuinely first-time contributors see the welcome message. Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com> Change-Id: I444ea6c1cdf6b41ddcd7669e1ee8803c8d2e1560
Darshan-upadhyay1110
force-pushed
the
private/darshan/correction-in-welcome-workflow
branch
from
dec019a to
704269d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The welcome message was posted on every PR from non-members because the author_association check treated NONE (no repo role) as a new contributor. Replace it with a PR count search so only genuinely first-time contributors see the welcome message.
Change-Id: I444ea6c1cdf6b41ddcd7669e1ee8803c8d2e1560
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay