Fix the scrolling issue when the image is clicked in navigation#15376
Open
GulsahKose wants to merge 1 commit intoCollaboraOnline:distro/collabora/co-25.04from
Open
Fix the scrolling issue when the image is clicked in navigation#15376GulsahKose wants to merge 1 commit intoCollaboraOnline:distro/collabora/co-25.04from
GulsahKose wants to merge 1 commit intoCollaboraOnline:distro/collabora/co-25.04from
Conversation
isWriter() introduced in 9951a62: Added scroll for Calc/Impress only, assuming Writer handles it via cursor events. That is wrong Writer's GotoFly uses SelectObj, not calc/impress UpdateCursor. !(isFollowingEditor() ||isFollowingUser()) introduced in 9951a62: Prevents scrolling when following any editor. In single-user mode you always follow yourself, so this blocks all Navigator scrolling. !TextSelections.getEndRectangle() introduced in 9ea89d7: Replaced !(_selectionHandles.end && _selectionHandles.end.isDragged) (check if handle is being dragged) with !TextSelections.getEndRectangle() (check if text selection exists). Not equivalent - Writer always has a text cursor. Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Change-Id: I077f7204fe3fa2bc5e213979ea36aea1d36228b9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isWriter() introduced in 9951a62:
Added scroll for Calc/Impress only, assuming Writer handles it via cursor events. That is wrong Writer's GotoFly uses SelectObj, not calc/impress UpdateCursor.
!(isFollowingEditor() ||isFollowingUser()) introduced in 9951a62: Prevents scrolling when following any editor. In single-user mode you always follow yourself, so this blocks all Navigator scrolling.
!TextSelections.getEndRectangle() introduced in 9ea89d7: Replaced !(_selectionHandles.end && _selectionHandles.end.isDragged) (check if handle is being dragged) with !TextSelections.getEndRectangle() (check if text selection exists). Not equivalent - Writer always has a text cursor.
Change-Id: I077f7204fe3fa2bc5e213979ea36aea1d36228b9
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay