Open
Conversation
timar
force-pushed
the
private/timar/404
branch
3 times, most recently
from
0e671bd to
35b1e30
Compare
Strip the sc_ (small-command) prefix in getIconNameOfCommand() so that sidebar .uno: toolbar buttons resolve to the correct lc_ SVG icons that COOL ships. Without this, sidebar controllers that register commands like sc_changecasetoupper produce icon lookups that don't match any file. Also: - skip legacy core sr* resource IDs (like sr20006) in icon lookup - add icon aliases: insertfooter, textbodyparastyle, showmultiplepages, showtwopages, validatedialogsa11y, validatesidebara11y - add changecasetoupper icon (light + dark) from colibre theme - add dark mode icon for ai_sidebar Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: I6a91b161af0269330265822440c3f0a87fbb104b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip the sc_ (small-command) prefix in getIconNameOfCommand() so that sidebar .uno: toolbar buttons resolve to the correct lc_ SVG icons that COOL ships. Without this, sidebar controllers that register commands like sc_changecasetoupper produce icon lookups that don't match any file.
Also:
showmultiplepages, showtwopages, validatedialogsa11y,
validatesidebara11y