Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

themes.json should contain the URL of the source file #188

Open
julien-f opened this issue Jul 21, 2015 · 5 comments
Open

themes.json should contain the URL of the source file #188

julien-f opened this issue Jul 21, 2015 · 5 comments
Labels

Comments

@julien-f
Copy link

IMHO, theme.json should have for each theme the URL of the source .tmTheme file.

These entries should then be used to regularly keep the themes up to date in this repo.

@blopker
Copy link
Member

blopker commented Jul 21, 2015

This issue has been brought up before, and it's something we would like to see. There are a few issues though.

  1. Validation of updated themes from arbitrary URLs scares the pants off me. This would have to be handled very carefully.
  2. We don't have any server infrastructure aside from GitHub and where ever we host the website. Adding services would require a large lift.

Also, I can only think of one developer ever updating their theme. Updating just doesn't seem to be a big issue right now.

@julien-f
Copy link
Author

I do not mean that the themes should be served by their URL, just that their repo should be properly referenced and that there should be a script in your repo to fetch the latest versions that you can then review and commit once satisfied.

@blopker
Copy link
Member

blopker commented Jul 21, 2015

Are you suggesting a script that we run locally at random intervals to pull in updated themes to the repo?

@julien-f
Copy link
Author

Yep, it's not perfect but it's still better than no updates or than forcing maintainers to create PRs on each update.

@blopker
Copy link
Member

blopker commented Jul 21, 2015

Sounds like a good compromise (first step even) instead of a automated solution. Not sure when we can get to it, but I'll leave this ticket open. Hopefully some kind soul will submit a PR :)

SecretDeveloper added a commit to SecretDeveloper/Colorsublime-Themes that referenced this issue Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants