Adding script to implement feature #188. #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, just noticed I had incorrectly added 2 duplicated theme files by accident with slightly different names which was causing the tests to fail. Corrected now. |
|
Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #188.
So I added a simple script that will attempt to download any themes which have a Url value defined. It continues to use the FileName value as the local filename. For themes with no Url defined then nothing should change, however if theme creators choose to include a Url then we can periodically update the version in the themes folder to ensure we have the latest.
Suggested flow:
npm run updateto download themes locally.npm run testto confirm each theme is parsable. I have some checks on the download to catch any weirdness but the tests will confirm content is valid.Also adding Monokai_SD theme.