N°8796 - Add PHP code style validation in iTop and extensions #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odain-cbd
added
enhancement
|
Ew, spaces for indentation? 😱 Current docs luckily still say to use tabs. |
thanks for this feedback. good catch! |
Hipska
reviewed
Oct 17, 2025
Comment on lines
-603
to
+611
| if (in_array($sHeader, $aField['columns'])) return true; | ||
| if (in_array($sHeader, $aField['columns'])) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Single line if-return should be allowed?
There was a problem hiding this comment.
nice to have but tricky to configure
PHP-CS-Fixer/PHP-CS-Fixer#2780
Comment on lines
+753
to
+756
| $sResult = self::CallItopViaHttp( | ||
| "/synchro/synchro_exec.php?login_mode=$sLoginform", | ||
| $aData | ||
| ); |
There was a problem hiding this comment.
What about
Suggested change
| $sResult = self::CallItopViaHttp( | |
| "/synchro/synchro_exec.php?login_mode=$sLoginform", | |
| $aData | |
| ); | |
| $sResult = self::CallItopViaHttp("/synchro/synchro_exec.php?login_mode=$sLoginform", $aData); |
Comment on lines
-108
to
+110
| Utils::Log(LOG_ERR, | ||
| "[".get_class($this)."] defaults section configuration is not correct. please see documentation."); | ||
| Utils::Log( | ||
| LOG_ERR, | ||
| "[".get_class($this)."] defaults section configuration is not correct. please see documentation." | ||
| ); |
There was a problem hiding this comment.
Similar here (and other Utils::Log calls), why can't it just be on 1 line? It's not that complicated to see what's happening?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current PR aims at validating code style easily via php-cs-fixer.
this tool is also integrated into Jenkins pipeline along to phpstan/phpunit.
Jenkins steps have been reordered logically (code style/phpstan/phpunit).
report generated in Jenkins is in verbose. you can have it by calling:
whole code base has been re-formatted. style will be clean starting with this PR.