Skip to content

Conversation

@Hipska
Copy link
Contributor

@Hipska Hipska commented Sep 4, 2025

Base information

Question Answer
Related to a SourceForge thread / Another PR / Combodo ticket? N/A
Type of change? Enhancement

Objective

Cleaner code in vSphereCollectionPlan::Init.

Proposed solution

Make use of Utils::CheckModuleInstallation.

Checklist before requesting a review

  • I have performed a self-review of my code, and that it's compliant with Combodo's guidelines
  • I have tested all changes I made on an iTop instance
  • I have added a unit test, otherwise I have explained why I couldn't
  • I have made sure the PR is clear and detailled enough so anyone can understand the real purpose without digging in the code

Checklist of things to do before PR is ready to merge

@Hipska
Copy link
Contributor Author

Hipska commented Sep 4, 2025

I would also change the logic for detecting TeemIP, if discovery is enabled, then the module should be considered as required rather than optional.

@Hipska Hipska changed the title Improve module installation checks by using integrated methods feat: Improve module installation checks by using integrated methods Sep 4, 2025
@Hipska Hipska marked this pull request as draft September 4, 2025 11:55
@github-project-automation github-project-automation bot moved this to First review needed in Combodo PRs dashboard Sep 4, 2025
@xtophe38
Copy link
Contributor

Good idea. But let's wait, first, that the method Utils::GetModuleVersion becomes available in itop-data-collector-base. It is currently a proposal, part of PR #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: First review needed

Development

Successfully merging this pull request may close these issues.

2 participants