Setup VRT #3894
Open
Setup VRT #3894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanmahajan7
commented
Oct 24, 2025
|
|
||
| env: | ||
| AUTHOR_NAME: 'github-actions[bot]' | ||
| AUTHOR_EMAIL: '41898282+github-actions[bot]@users.noreply.github.com' |
There was a problem hiding this comment.
Copied some of the instructions from https://vitest.dev/guide/browser/visual-regression-testing.html#the-update-workflow
| /> | ||
| ); | ||
|
|
||
| await expect(getGrid()).toMatchScreenshot('basic-grid'); |
There was a problem hiding this comment.
We can tweak the match options if needed
https://vitest.dev/guide/browser/visual-regression-testing.html#global-configuration
Co-authored-by: amanmahajan7
Co-authored-by: amanmahajan7
nstepien
reviewed
Oct 24, 2025
| git config --global user.email "${{ env.AUTHOR_EMAIL }}" | ||
| git add test/visual/__screenshots__/. | ||
| git diff-index --quiet HEAD || git commit -m "${{ env.COMMIT_MESSAGE }}" | ||
| git push --set-upstream origin ${{ github.head_ref }} |
There was a problem hiding this comment.
Does this work for forked repos?
Do we need --set-upstream?
There was a problem hiding this comment.
Does this work for forked repos?
Not sure. We can revisit if needed. Wdyt?
Do we need --set-upstream?
Not needed
Co-authored-by: Nicolas Stepien <[email protected]>
Co-authored-by: amanmahajan7
nstepien
reviewed
Oct 24, 2025
Co-authored-by: Nicolas Stepien <[email protected]>
This reverts commit 6928269.
Co-authored-by: amanmahajan7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://vitest.dev/guide/browser/visual-regression-testing.html#visual-regression-testing
This PR sets up VRT. We can use
Update Screenshotslabel to update screenshots when needed