Skip to content

Fixed aria2 download issues and Added aria2 resumable download #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed aria2 download issues and Added aria2 resumable download #2061

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4980f6b
Fix: The file save path is incorrect when downloading with aria2.
skyzhang0 Aug 5, 2025
2bcae64
Add a suffix to unfinished files to enable aria2's resumable download…
skyzhang0 Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions glob/manager_downloader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,8 @@ def aria2_download_url(model_url: str, model_dir: str, filename: str):
import tqdm
import time

if model_dir.startswith(core.comfy_path):
model_dir = model_dir[len(core.comfy_path) :]

download_dir = model_dir if model_dir.startswith('/') else os.path.join('/models', model_dir)
download_dir = model_dir
filename += '.downloading' # aria2 uses .downloading suffix for incomplete files

download = aria2_find_task(download_dir, filename)
if download is None:
Expand All @@ -104,6 +102,17 @@ def aria2_download_url(model_url: str, model_dir: str, filename: str):
progress_bar.update(download.completed_length - progress_bar.n)
time.sleep(1)
download.update()

if download.is_complete and download.completed_length == download.total_length:
file_path = os.path.join(download_dir, filename)
final_path = file_path[:-len('.downloading')] # remove the .downloading suffix
if os.path.exists(file_path):
os.rename(file_path, final_path)
logging.info(f"Download completed: {final_path}")
else:
logging.error(f"Download directory {file_path} does not exist after download completion.")
else:
logging.error(f"Download failed or incomplete: {download.status} for {model_url}")


def download_url_with_agent(url, save_path):
Expand Down