backport(pr-6499): unified app:run_triggered event onto rh-test
#6501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benceruleanlu
requested review from
Myestery,
christian-byrne and
comfyui-wiki
as code owners
dosubot
bot
added
the
size:L
🎭 Playwright Test Results❌ Some tests failed ⏰ Completed at: 11/01/2025, 07:08:59 PM UTC 📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
dosubot
bot
added
size:M
christian-byrne
added
the
claude-review
…ons (#6499) Summary - Add new telemetry event: `app:run_triggered` with `{ trigger_source: 'button' | 'keybinding' | 'menu' }`. - Instrument all run initiation paths: - UI Queue button emits `run_triggered` (source `button`) and keeps emitting `run_button_click` for UI-only tracking. - Keybindings (Ctrl+Enter / Ctrl+Shift+Enter) emit `run_triggered` (source `keybinding`). - Menus (menubar + legacy menu buttons) emit `run_triggered` (source `menu`). - Mixpanel provider now supports `trackRunTriggered` and forwards `run_triggered`. - `execution_start` tracking remains unchanged. Motivation GTM observed more `execution_start` events than `run_button_click`. This change clarifies attribution by adding a unified event across all triggers while preserving the UI-only `run_button_click` metric. Files - src/platform/telemetry/types.ts: Add `RunTriggeredMetadata`, `RUN_TRIGGERED`, provider method signature. - src/platform/telemetry/providers/cloud/MixpanelTelemetryProvider.ts: Implement `trackRunTriggered`. - src/components/actionbar/ComfyRunButton/ComfyQueueButton.vue: Emit `run_triggered` on button path. - src/services/keybindingService.ts: Emit `run_triggered` when queue commands are invoked via keybindings. - src/stores/menuItemStore.ts: Emit `run_triggered` for queue commands invoked via menubar. - src/scripts/ui.ts: Emit `run_triggered` for legacy menu queue buttons. Notes - `run_button_click` continues to represent UI button presses only. - `run_triggered` now represents all user-initiated runs with clear source attribution. QA - Cloud build: verify `app:run_triggered` appears with the correct `trigger_source` for button, keybinding, and menu triggers. - Verify `app:run_button_click` only fires for the button path. - Confirm `execution_start` still tracks as before. If preferred, we can extend `run_triggered` with additional fields (e.g., queue mode, batchCount) in a follow-up. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6499-feat-telemetry-add-unified-run_triggered-event-for-all-run-initiations-29e6d73d3650819fb481d3e0e925c50f) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <[email protected]>
christian-byrne
force-pushed
the
backport-6499-to-rh-test
branch
from
c0777db to
777e751
Compare
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Contributor
|
Updated this PR with a clean backport from the merged commit on main. Changes made:
Result:
The backport is now ready for review and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of upstream PR #6499 onto
rh-test.Summary
app:run_triggeredwith{ trigger_source: 'button' | 'keybinding' | 'menu' }.run_triggered(sourcebutton) and still emitsrun_button_clickfor UI-only tracking.run_triggered(sourcekeybinding).run_triggered(sourcemenu).trackRunTriggered.execution_startlogic.Files changed (matching PR #6499 exactly)
Notes
workflow_opened).--no-verifyto avoid adding non-PR changes. Lint and typecheck pass locally (pnpm lint:fix && pnpm typecheck).Upstream reference: #6499
┆Issue is synchronized with this Notion page by Unito